auth: fix cluster init deadlock #49638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the bootstrapped resources are created but a failure occurs later in the cluster init process subsequent runs of the cluster initialization will fail due to the existing bootstrap resources.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
dboslee
changed the title
|
Is this something we can get some test coverage for? |
zmb3
reviewed
Dec 3, 2024
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
zmb3
approved these changes
Dec 3, 2024
bl-nero
reviewed
Dec 5, 2024
bl-nero
approved these changes
Dec 6, 2024
public-teleport-github-review-bot
bot
removed request for
strideynet,
hugoShaka and
fspmarshall
dboslee
added a commit
that referenced
this pull request
Dec 9, 2024
* auth: fix cluster init deadlock If the bootstrapped resources are created but a failure occurs later in the cluster init process subsequent runs of the cluster initialization will fail due to the existing bootstrap resources. * add test for new behavior * add test for cluster init failures recovery * Update lib/services/local/resource_test.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * reorder assertion values --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
dboslee
added a commit
that referenced
this pull request
Dec 10, 2024
* auth: fix cluster init deadlock If the bootstrapped resources are created but a failure occurs later in the cluster init process subsequent runs of the cluster initialization will fail due to the existing bootstrap resources. * add test for new behavior * add test for cluster init failures recovery * Update lib/services/local/resource_test.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * reorder assertion values --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
* auth: fix cluster init deadlock If the bootstrapped resources are created but a failure occurs later in the cluster init process subsequent runs of the cluster initialization will fail due to the existing bootstrap resources. * add test for new behavior * add test for cluster init failures recovery * Update lib/services/local/resource_test.go * reorder assertion values --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the bootstrapped resources are created but a failure occurs later in the cluster init process subsequent runs of the cluster initialization will fail due to the existing bootstrap resources.
changelog: Improved the cluster initialization process's ability to recovery from errors