[Web] Fix re-rendering loop in unified resources #49725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
force-pushed
the
yassine/fix-rerender-loop
branch
from
8a572d4 to
07e3007
Compare
flyinghermit
approved these changes
Dec 3, 2024
avatus
approved these changes
Dec 3, 2024
public-teleport-github-review-bot
bot
removed request for
ravicious and
gzdunek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR resolves #49504
This PR resolves #49601
This PR fixes a bug causing the unified resources page to rerender multiple times when filtering resources, in some cases in an infinite loop.
This was caused by a 3 year old
useEffectinuseServerSideSearchPanelwhich is no longer necessary after the many updates to the resources page and filtering logic since then.This PR also streamlines our param-setting logic such that params are always set by the primary
setParamsfunction fromuseUrlFiltering, previously there would be places where we directly manipulated the URL viareplaceHistory, causing duplicate code and creating a potential for inconsistencies.changelog: Fix re-rendering bug when filtering Unified Resources