fix: Take TTL into account when renewing sessions #49732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
avatus
approved these changes
Dec 3, 2024
zmb3
reviewed
Dec 3, 2024
|
PTAL? |
zmb3
approved these changes
Dec 4, 2024
public-teleport-github-review-bot
bot
removed request for
ryanclark,
kiosion and
kimlisa
|
@codingllama See the table below for backport results.
|
This was referenced Dec 4, 2024
codingllama
added a commit
that referenced
this pull request
Jan 29, 2025
This reverts commit ec870e1.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
This reverts commit ec870e1.
codingllama
added a commit
that referenced
this pull request
Jan 29, 2025
This reverts commit ec870e1.
codingllama
added a commit
that referenced
this pull request
Jan 29, 2025
codingllama
added a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take the session TTL into account before triggering a session renewal. This avoids a tight renewal loop for sessions with 30s <= TTL <= 3m.
The "ttl/10" fraction and 30s floor values are chosen arbitrarily. A too low max_session_ttl (30s or less) will still tightly loop renewals - this PR doesn't attempt to avoid that.
#49629
Changelog: Avoid tight web session renewals for sessions with short TTL (between 3m and 30s)