-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating OS Package metadata: license and description #49793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM provided that this builds/releases without issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment.
Also note that the licensing rules changed with v16, so this should not be backported to v15.
build.assets/build-package.sh
Outdated
@@ -74,9 +74,9 @@ FPM_IMAGE_RPM="public.ecr.aws/gravitational/fpm:centos8-1.15.1-1" | |||
|
|||
# extra package information for linux | |||
MAINTAINER="info@goteleport.com" | |||
LICENSE="Apache-2.0" | |||
LICENSE="AGPL-3.0-or-later" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The packages we distribute are governed by build.assets/LICENSE-community
, NOT by AGPLv3.
We should change this (is there a way to use a custom license in a package?), and we should also be including a copy of LICENSE-community
in the package itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok the task we had wasn't entirely clear on what was necessary. Thanks for the additional context.
We should be able to use a custom license. Afaik this just takes in an arbitrary string. Unfortunately there's not really a way to query for the contents of the license itself. Maybe we could provide a link to the license in the description?
Adding the LICENSE-community
should be easy enough though. Just need to update build-archive
to include it in the tarball.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose its even a little more complicated than that, as the -ent
packages are not governed by LICENSE-community
.
Dev build: https://github.com/gravitational/teleport.e/actions/runs/12205154596#artifacts Tarball
RPM
deb
|
@doggydogworld See the table below for backport results.
|
Updates our OS packages (.rpm, .deb, etc) metadata to be up-to-date. Previous to this change it contained out-of-date information for our license and description.
changelog: Our OSS OS packages (rpm, deb, etc) now have up-to-date metadata.