Backwards compatible SSH port forwarding controls #50043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
reviewed
Dec 11, 2024
eriktate
force-pushed
the
eriktate/backward-compatible-ssh-port-forward-controls
branch
from
6bee479 to
7045356
Compare
eriktate
added
the
no-changelog
timothyb89
approved these changes
Dec 12, 2024
eriktate
force-pushed
the
eriktate/backward-compatible-ssh-port-forward-controls
branch
2 times, most recently
from
b4cb01e to
9843660
Compare
rosstimothy
reviewed
Dec 12, 2024
rosstimothy
reviewed
Dec 12, 2024
eriktate
force-pushed
the
eriktate/backward-compatible-ssh-port-forward-controls
branch
from
9843660 to
2c2c03c
Compare
rosstimothy
reviewed
Dec 13, 2024
rosstimothy
approved these changes
Dec 13, 2024
public-teleport-github-review-bot
bot
removed the request for review
from vapopov
eriktate
force-pushed
the
eriktate/backward-compatible-ssh-port-forward-controls
branch
from
2c2c03c to
363e22d
Compare
rosstimothy
reviewed
Dec 13, 2024
eriktate
force-pushed
the
eriktate/backward-compatible-ssh-port-forward-controls
branch
from
363e22d to
21e8ba6
Compare
eriktate
deleted the
eriktate/backward-compatible-ssh-port-forward-controls
branch
eriktate
added a commit
that referenced
this pull request
Dec 13, 2024
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a permanent transformation of roles fetched over gRPC that assigns a value to
port_forwardingbased on thessh_port_forwardingconfiguration. This preserves backwards compatibility when communicating with agents that aren't aware of the newerssh_port_forwardingfield without impacting newer agents since they will drop the configuredport_forwardingvalue in favor of the newer configuration.