[v16] Prevent forwarded tcpip requests hanging indefinitely #50239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
The SSH channel was only being closed in the happy path once proxying of data completed. This resulted in any connections being made, and failing for any reason prior to that hanging until the user terminated the request. The behavior from the regular.Server was copied to the forward.Server to ensure that the channel is always closed when handleDirectTCPIPRequest terminates.
rosstimothy
force-pushed
the
tross/backport-50209/v16
branch
from
d641363 to
adcf2bc
Compare
codingllama
approved these changes
Dec 13, 2024
eriktate
approved these changes
Dec 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #50209 to branch/v16
changelog: Properly close ssh port forwarding connections to prevent requests hanging indefinitely.