Migrate dynamodb engine to AWS SDK v2 #50250
Conversation
GavinFrazar
added
the
no-changelog
github-actions
bot
added
database-access
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
GavinFrazar
added
aws
GavinFrazar
force-pushed
the
gavinfrazar/migrate-dynamodb-engine-sdk
branch
from
a036fa2 to
b113763
Compare
| "github.com/aws/aws-sdk-go/service/dynamodb" | ||
| "github.com/aws/aws-sdk-go/service/dynamodbstreams" | ||
| "github.com/aws/aws-sdk-go-v2/aws" | ||
| "github.com/aws/aws-sdk-go-v2/service/dax" |
There was a problem hiding this comment.
The dax APIs sourced here are only for deployment, not for interacting with the "database".
I don't think db access works with dax today: https://github.com/aws/aws-dax-go
I propose we drop dax here and track dax separately. WDYT
There was a problem hiding this comment.
You're right that these are only for API operations, e.g.
aws dax describe-clusters --endpoint-url http://localhost:8000
The alternative is to have app access for AWS console set up and use tsh aws dax instead.
App access is a better UX anyway since DynamoDB db-access has to support nosql workbench, which requires using the fake "local" region and configuring a db per region.
I would prefer to drop DAX support in a separate PR at least to limit this to just converting SDK version.
This migrates the Database Service engine for DynamoDB to use AWS SDK v2. FIPS endpoint resolution has also been enabled. Finally, the engine will now resolve to the AWS-account-based endpoint for DynamoDB operations in supported regions.
GavinFrazar
force-pushed
the
gavinfrazar/migrate-dynamodb-engine-sdk
branch
from
b113763 to
978fdce
Compare
Changelog: Teleport Database Service will now resolve DynamoDB endpoints to AWS-account-based endpoints in supported regions.
Part of #14142
This migrates the Database Service engine for DynamoDB to use AWS SDK v2.
FIPS endpoint resolution has also been enabled.
Finally, if the AWS account ID is known1 then the engine will resolve to the account ID based endpoint for DynamoDB operations in supported regions.
Footnotes
I think it was always a required
dbspec field, but it's trivial to handle the case where it isn't, because that was prior behavior anyway ↩