-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Vite & related packages to latest #50617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, electron-vite doesn't support v6 yet. In practice, the app seems to work fine in dev and packaged mode.
There's an issue about Vite 6 support (alex8088/electron-vite#673). The maintainer said a month ago that they're working on it. In the meantime, someone created a PR which bumps Vite alex8088/electron-vite#689. But if updating it to v6 was as simple as bumping a version in the package.json, I assume the maintainers would've already done it.
I quickly checked Storybook and Web UI and they seem to work on my machine as well. 👍
I'm not sure if we want to backport it this far. We typically don't backport dep updates, unless not backporting them is going to make other backports harder. |
I'd say let's take a risk and merge this. The v6 migration guide doesn't seem to mention breaking changes in features that we use, so hopefully electron-vite is going to work fine. Especially if we just don't backport this, there will be minimal risk. Merging this unblocks #50666, which otherwise gets blocked on vite-plugin-react-swc not working for some reason. #50666 (comment) |
I was planning on backporting this, would you prefer if we just kept master on v6? I don't mind considering there aren't any issues with v5 and I don't think we're missing out on much |
@ryanclark See the table below for backport results.
|
You can try if you want, but since we haven't been backporting dep updates in general, there might be some unforeseen issues on v17 like, idk, Storybook being on an old version. OTOH v17 was cut not that long ago so maybe this will merge just fine. |
This upgrades Vite & any Vite plugin/SWC plugin to latest (moving Vite from v5 to v6).