Move import sorting over to prettier

[ryanclark]

This removes eslint-plugin-import and moves import sorting over to prettier instead.

[kiosion]

lgtm!

[ravicious]

The Prettier plugin makes more opinionated choices than the ESLint plugin which ultimately makes the configuration much simpler (it has mostly to do with how types are sorted).

[ravicious]

I added a commit with a bunch of proposed changes, let me know what you think.

• A clear split of our own packages between app packages and "library" packages. Taken from tsconfig.json to minimize the amount of places that need to be updated when something changes. gen-proto-ts is treated as a library package. @gravitational/* imports are grouped together with those without that prefix.
• Node builtins go at the top. No strong opinion on this, it's just something we've been following in teleterm where we have the biggest amount of Node code. I guess it makes it easier to see that the code in the file is Node-only?

[ravicious]

On my machine, adding the sort plugin makes pnpm prettier-check go from ~17-20s to ~27s. The ESLint plugin made pnpm eslint slower by ~0-3s. I guess it's not necessarily an issue in the grand scheme of things, I just wanted us to be aware of this.

[ravicious]

I also see in the readme of this plugin that it "combines type and value imports (if importOrderTypeScriptVersion is set to "4.5.0" or higher)". @kiosion I think you had some opinions on this?

[kiosion]

Ah, yeah. Not sure if it's still the case, would need to look into it again, but I remember there being some issues in the past regarding combined type/code imports and proper tree-shaking of unused imports... aside from that it's a stylistic preference (I find having all type-related imports grouped together is much more readable).

[ravicious]

FWIW, it should be possible to separate type imports from regular imports with this plugin, but we'd need to add a regex for each import group to avoid grouping all type imports. Grouping regular imports but not grouping type imports feels a bit off to me.

<TYPES> - Not active by default, this allows you to group all type-imports, or target them with a regex (<TYPES>^[.] targets imports of types from local files).

But the way the plugin does it right now is fine for me.

[zmb3]

LGTM, let's resolve the conflicts and get it merged.

Do we plan to backport this to avoid merge conflicts with backports?

[ryanclark]

LGTM, let's resolve the conflicts and get it merged.

Do we plan to backport this to avoid merge conflicts with backports?

Yeah

[public-teleport-github-review-bot]

@ryanclark See the table below for backport results.

Branch	Result
branch/v15	Failed
branch/v16	Failed
branch/v17	Failed