Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix file name for sql server ad instrs #50869

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

docs: fix file name for sql server ad instrs #50869

wants to merge 3 commits into from
+2 −2

Conversation

stevenGravy
Copy link
Contributor

@stevenGravy stevenGravy commented Jan 8, 2025 •
edited
Loading

includes verbiage update from #51034 for openssh

@stevenGravy stevenGravy added the no-changelog Indicates that a PR does not require a changelog entry label Jan 8, 2025
@stevenGravy stevenGravy enabled auto-merge January 8, 2025 14:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
stevenGravy/docs/sqlserverad 0b4b898 3 ✅SUCCEED stevengravy-docs-sqlserverad 2025-01-14 19:40:20

@stevenGravy stevenGravy disabled auto-merge January 14, 2025 18:58
rosstimothy
rosstimothy reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@rosstimothy rosstimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intended to include #50906?

@stevenGravy stevenGravy enabled auto-merge January 14, 2025 19:26
@stevenGravy
Copy link
Contributor Author

Was this intended to include #50906?

Yes, so it includes the update to the verbiage @ptgott suggested in #51034

@rosstimothy
Copy link
Contributor

Can you update the PR and title description to indicate that this is fixing two things? It's a bit confusing as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosstimothy rosstimothy rosstimothy left review comments

@ptgott ptgott ptgott approved these changes

@gabrielcorado gabrielcorado gabrielcorado approved these changes

@greedy52 greedy52 Awaiting requested review from greedy52

@mmcallister mmcallister Awaiting requested review from mmcallister

@r0mant r0mant Awaiting requested review from r0mant

@xinding33 xinding33 Awaiting requested review from xinding33

@zmb3 zmb3 Awaiting requested review from zmb3

Assignees
No one assigned
Labels
backport/branch/v15 backport/branch/v16 backport/branch/v17 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenGravy @rosstimothy @gabrielcorado @ptgott