Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserTasks - DiscoverRDS issues: add RDS known issues #50986

Merged
merged 2 commits into from
Jan 20, 2025
Merged

UserTasks - DiscoverRDS issues: add RDS known issues #50986

merged 2 commits into from
Jan 20, 2025

Conversation

marcoandredinis
Copy link
Contributor

This PR adds a single RDS issue so that it's easier to review. Other issues will be added later on.

@marcoandredinis marcoandredinis added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Jan 13, 2025
@marcoandredinis marcoandredinis mentioned this pull request Jan 13, 2025
Open
@marcoandredinis marcoandredinis changed the title UserTasks - Discover RDS issues: add RDS known issues UserTasks - DiscoverRDS issues: add RDS known issues Jan 13, 2025
Base automatically changed from marco/usertasks_rds_proto to master January 14, 2025 09:30
@marcoandredinis marcoandredinis force-pushed the marco/usertasks_rds_issues branch from d58cb2f to bbd67e6 Compare January 14, 2025 10:16
@marcoandredinis
Copy link
Contributor Author

@rudream @smallinsky Friendly ping

@marcoandredinis marcoandredinis force-pushed the marco/usertasks_rds_issues branch 2 times, most recently from 42e6977 to 2caafea Compare January 17, 2025 11:11
camscale
camscale approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@camscale camscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a few minor nitpicks really.

api/types/usertasks/object.go Outdated Show resolved Hide resolved
lib/usertasks/urls.go Outdated Show resolved Hide resolved
lib/usertasks/urls.go Outdated Show resolved Hide resolved
lib/usertasks/urls.go Outdated Show resolved Hide resolved
@marcoandredinis
UserTasks - Discover RDS issues: add RDS known issues
7271dc3 
This PR adds a single RDS issue so that it's easier to review.
Other issues will be added later on.
@marcoandredinis
review
2ac35b1
@marcoandredinis marcoandredinis force-pushed the marco/usertasks_rds_issues branch from 2caafea to 2ac35b1 Compare January 20, 2025 13:51
@marcoandredinis marcoandredinis added this pull request to the merge queue Jan 20, 2025
Merged via the queue into master with commit d1f2ee0 Jan 20, 2025
44 checks passed
@marcoandredinis marcoandredinis deleted the marco/usertasks_rds_issues branch January 20, 2025 14:32
@public-teleport-github-review-bot
Copy link

@marcoandredinis See the table below for backport results.

Branch Result
branch/v17 Create PR

@marcoandredinis marcoandredinis mentioned this pull request Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camscale camscale camscale approved these changes

@tigrato tigrato tigrato approved these changes

Assignees
No one assigned
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoandredinis @tigrato @camscale