Vendor gravitational/trace/trail in api #51032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling in the trail package directly in api will allow the trace module to shed the grpc-go dependency. This needs to land prior to gravitational/trace#112 being included in a new version of trace. There should be no noticable change in the api depdency tree since it already depends on grpc-go. Some additional items from the trace/internal package were also vendored within trail as needed. Additionally, some of the public api of trail that was not being consumed has been made private.
rosstimothy
added
the
no-changelog
github-actions
bot
added
database-access
github-actions
bot
requested review from
espadolini,
greedy52,
hugoShaka,
marcoandredinis and
tigrato
tigrato
approved these changes
Jan 14, 2025
codingllama
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
This is a straight copy from trace, correct? (Just checking.)
There was a problem hiding this comment.
The only differences are as mentioned in the description, a few public things were made private as they weren't consumed and some items from trace/internal were also included here. The only real changes are included separately in 4f20f2d to appease the linters.
public-teleport-github-review-bot
bot
removed request for
marcoandredinis,
espadolini,
greedy52 and
hugoShaka
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in the trail package directly in api will allow the trace module to shed the grpc-go dependency. This needs to land prior to gravitational/trace#112 being included in a new version of trace.
There should be no noticeable change in the api dependency tree since it already depends on grpc-go. Some additional items from the trace/internal package were also vendored within trail as needed. Additionally, some of the public api of trail that was not being consumed has been made private.
The conversion will be complete once https://github.com/gravitational/teleport.e/pull/5843 lands and a new version of trace is published and used in go.mod.