Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix defunct TestX11Forward #51035

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix defunct TestX11Forward #51035

wants to merge 2 commits into from
+11 −6

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Jan 14, 2025

#43756 introduced two issues in the X11 forwarding test:

  • The test would end without waiting for the test requests, because of a flipped <
  • The test would (correctly) end with a context canceled error when the x11 forwarding request is closed, due to using utils.ProxyConn instead of x11.Forward, which handles context differently

Closes #48288

@Joerger Joerger changed the title Restore defunct TestX11Forward Fix defunct TestX11Forward Jan 14, 2025
@rosstimothy rosstimothy added the no-changelog Indicates that a PR does not require a changelog entry label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosstimothy rosstimothy rosstimothy approved these changes

@rudream rudream Awaiting requested review from rudream

@timothyb89 timothyb89 Awaiting requested review from timothyb89

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestX11Forward flakiness
2 participants
@Joerger @rosstimothy