Init local metrics registry at runtime instead of config #51074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
added
the
no-changelog
hugoShaka
changed the title
rosstimothy
approved these changes
Jan 15, 2025
espadolini
approved these changes
Jan 15, 2025
public-teleport-github-review-bot
bot
removed request for
zmb3,
codingllama and
rudream
hugoShaka
added a commit
that referenced
this pull request
Jan 17, 2025
hugoShaka
added a commit
that referenced
this pull request
Jan 17, 2025
hugoShaka
added a commit
that referenced
this pull request
Jan 17, 2025
hugoShaka
added a commit
that referenced
this pull request
Jan 17, 2025
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
hugoShaka
added a commit
that referenced
this pull request
Jan 21, 2025
hugoShaka
added a commit
that referenced
this pull request
Jan 21, 2025
hugoShaka
added a commit
that referenced
this pull request
Jan 21, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Use a non-global metrics registry in Teleport (#50913) * Support a non-global registry in Teleport * lint * Update lib/service/service.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Serve metrics from the local registry in the diagnostic service (#51031) * Use local metrics registry in the diagnostic service * Test metrics are served by the diag service * Init local registry at runtime instead of config (#51074) * lint --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Use a non-global metrics registry in Teleport (#50913) * Support a non-global registry in Teleport * lint * Update lib/service/service.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Serve metrics from the local registry in the diagnostic service (#51031) * Use local metrics registry in the diagnostic service * Test metrics are served by the diag service * Init local registry at runtime instead of config (#51074) --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Use a non-global metrics registry in Teleport (#50913) * Support a non-global registry in Teleport * lint * Update lib/service/service.go Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com> * Serve metrics from the local registry in the diagnostic service (#51031) * Use local metrics registry in the diagnostic service * Test metrics are served by the diag service * Init local registry at runtime instead of config (#51074) * lint --------- Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the metrics registry again 🙄
This PR makes the local registry init happen in
NewTeleport()(at run time) instead ofApplyDefaults()(config time).We have some integration tests stopping and starting Teleport processes using the same config. The second startup caused metrics double registration in #50807.
Required for: #50807