Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional component props to Roles component #51322

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

avatus
Copy link
Contributor

@avatus avatus commented Jan 22, 2025

This PR enables us to add an optional RoleDiff component to the props for our Roles feature so that we can create an "e wrapper" around the Roles feature for enterprise specifically. Then we can pass the Role Diff visualizer into the E route.

Adds support (for this stub) in https://github.com/gravitational/teleport.e/pull/5902

@avatus avatus added the no-changelog Indicates that a PR does not require a changelog entry label Jan 22, 2025
@avatus avatus requested review from ryanclark and bl-nero January 22, 2025 00:07
@github-actions github-actions bot requested a review from gzdunek January 22, 2025 00:07
@avatus avatus removed the request for review from gzdunek January 22, 2025 00:08
This PR enables us to add an optional RoleDiff component to the props
for our Roles feature so that we can create an "e wrapper" around the
Roles feature for enterprise specifically. Then we can pass the Role
Diff visualizer into the E route.
{roleDiffProps ? (
<roleDiffProps.RoleDiffComponent />
) : (
<Box maxWidth={promoImageWidth + 2 * 2} minWidth={300}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the diff is a bit wild on this one due to a lot of similar child components, but i didnt change anything with the structure of the Coming Soon box, just moved it into the tertiary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant