[v16] Add client-side functions to export multiple authorities #51363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually backported from #51359, cherry-picked commit-by-commit. This branch doesn't have the integrations logic (ExportAuthoritiesRequest.shouldExportIntegration), neither does lib/cryptosuites exist (which used for testing). The former I fixed when cherry-picking the commits themselves (as it's most about removing lines), the latter I fixed on a separate commit ("Fix TestExportAllAuthorities_mutipleActiveKeys for backport" / 59679dd). I'll cherry pick v15 from this one. |
codingllama
added
the
no-changelog
codingllama
commented
Jan 22, 2025
| t.Run(tt.name, func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| t.Run(fmt.Sprintf("%s/ExportAllAuthorities", tt.name), func(t *testing.T) { |
There was a problem hiding this comment.
I just noticed that the "%s/" is silly, this is already running in a subtest named after tt.name. I have some cleanups for master so I'll fix it there and backport to release branches.
zmb3
approved these changes
Jan 22, 2025
greedy52
approved these changes
Jan 22, 2025
public-teleport-github-review-bot
bot
removed the request for review
from hugoShaka
codingllama
force-pushed
the
codingllama/export-all-funcs-v16
branch
from
5c23e20 to
737b6d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #51189 to branch/v16.
#35444