[v16] feat: Support multiple active CAs in Web exports #51418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move /auth/export code to own file * Implement "/auth/export?format=zip" * Refactor existing tests * Test format=zip * Fix comment * Use bytes.NewReader * Remove lib/client.ExportAuthorities
codingllama
commented
Jan 23, 2025
| name: "all", | ||
| expectedStatus: http.StatusOK, | ||
| assertBody: func(t *testing.T, b []byte) { | ||
| require.Contains(t, string(b), "@cert-authority localhost,*.localhost ssh-rsa ") |
There was a problem hiding this comment.
The test table assertions are a bit different here in comparison to v17/master - the latter wants "ecdsa-sha2-nistp256 " whereas here we have "ssh-rsa ". These are "old" assertions, so I just made sure they match the moved code from this branch.
|
Friendly ping @probakowski @zmb3. |
zmb3
approved these changes
Jan 24, 2025
rosstimothy
approved these changes
Jan 24, 2025
public-teleport-github-review-bot
bot
removed the request for review
from probakowski
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #51301 to branch/v16.
#35444
Changelog: Added support for multiple active CAs in the /auth/export endpoint