fix(Select): keyboard behavior on mobile #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Visual Tests Report is ready. |
|
@iapolya Hi! Could u fix failed test? |
iapolya
force-pushed
the
feat/select-close-on-mobile
branch
2 times, most recently
from
73c056a to
e9c0afa
Compare
|
@korvin89 ping |
ValeraS
requested changes
Feb 5, 2025
iapolya
force-pushed
the
feat/select-close-on-mobile
branch
from
b6c837e to
ebdd9b2
Compare
iapolya
force-pushed
the
feat/select-close-on-mobile
branch
3 times, most recently
from
714d265 to
b1df335
Compare
iapolya
force-pushed
the
feat/select-close-on-mobile
branch
from
b1df335 to
00b2481
Compare
korvin89
reviewed
Feb 11, 2025
src/components/Select/Select.tsx
Outdated
| @@ -241,6 +244,7 @@ export const Select = React.forwardRef<HTMLButtonElement, SelectProps>(function | |||
| }, | |||
| [handleClose, onBlur], | |||
| ), | |||
| isDisabled: mobile, | |||
There was a problem hiding this comment.
Lets remove this line and don't call handleClose in onBlurWithin in case of mobile device
iapolya
force-pushed
the
feat/select-close-on-mobile
branch
from
00b2481 to
8dc8058
Compare
ValeraS
requested changes
Feb 12, 2025
iapolya
force-pushed
the
feat/select-close-on-mobile
branch
from
8dc8058 to
0bc4153
Compare
iapolya
force-pushed
the
feat/select-close-on-mobile
branch
from
0bc4153 to
d24b377
Compare
ValeraS
approved these changes
Feb 12, 2025
korvin89
approved these changes
Feb 12, 2025
mournfulCoroner
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases when the select with an open keyboard behaves inconveniently for the user
Click on "Готово" button
IMG_2814.MP4
IMG_2815.MP4
Questions:
filterRef.current?.focus()on mobile?