fix: fixed tooltip render on pin with empty data (#176)

gravity-ui · Nov 8, 2023 · 52a0847 · 52a0847
1 parent c615d33
commit 52a0847
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/YagrCore/plugins/tooltip/tooltip.ts b/src/YagrCore/plugins/tooltip/tooltip.ts
@@ -465,6 +465,15 @@ class YagrTooltip {
                 x,
             };
 
+            const hasDataNow = Object.values(sections).some(
+                ({rows}) => rows.filter(({id}) => this.yagr.getSeriesById(id)?.show).length > 0,
+            );
+
+            if (!hasDataNow) {
+                this.hide();
+                return;
+            }
+
             if (!opts.virtual) {
                 this.tOverlay.innerHTML = opts.render({
                     ...renderData,

diff --git a/src/YagrCore/utils/series.ts b/src/YagrCore/utils/series.ts
@@ -132,6 +132,7 @@ export function configureSeries(yagr: Yagr, rawSeries: RawSerieData, idx: number
 
 export const overrideSeriesInUpdate = (dest: Series, source: Series) => {
     dest.$c = source.$c ?? dest.$c;
+    dest.show = source.show ?? dest.show;
     dest.data = source.data ?? dest.data;
     dest.width = source.width ?? dest.width;
     dest.pointsSize = source.pointsSize ?? dest.pointsSize;