fix(core): allow shuffle to return first element in first index #3070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
randomSubset
with length 1 never returns the first element. This is becauseshuffle
makes it impossible for the first element of the shuffled array to be the same as the first element of the original array, andrandomSubset
slices the shuffled array up tolength
to return the subset.Fixes: #1780
What is the new behavior?
shuffle
can now potentially return an array with the first element being the first element of the original array, so callingrandomSubset
with length 1 can return the first element.Does this PR introduce a breaking change?
Other information