-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint): add linting rules for test describe depth #3056
Conversation
This is awesome! @griest024 do you think we should set depth to 4 as warning, and 5 as error? I only see a few with 5, but many more with 3/4. |
@damienwebdev 5 as an error sounds good. Can we mix error and warning values for the same rule? Afaik eslint does not allow for this. |
daffodil/tools/eslint/config/package.json Line 14 in d41bc5a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Needs @griest024 approval for merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
needs a rebase |
@gracetxgao Needs another rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #122
What is the new behavior?
Maximum describe() depth of 3 set for tests.
Does this PR introduce a breaking change?
Other information