feat(daffio): add effect to sub to activated route #2987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griest024
added
package: daff.io
damienwebdev
requested changes
Aug 15, 2024
| import { DaffRouterActivatedRoute } from '@daffodil/router'; | ||
|
|
||
| // TODO: should this be moved to `@daffodil/router/state`? | ||
| export const daffioRouterActivatedRoute = createEffect( |
There was a problem hiding this comment.
What's the difference between this and a regular observable of the route? That it can be loaded via EffectModule?
There was a problem hiding this comment.
yeah it felt appropriate to put it in an effect but there's no real functional benefit over just subbing in the AppModule
There was a problem hiding this comment.
Is there a way that we can make something like "pseudoeffects" that automatically sub in the AppModule? I'd like to keep a safe distance ( as best we can) between @ngrx and anything router related.
There was a problem hiding this comment.
oh yeah we can use an APP_INITIALIZER, good idea
|
closed in favor of #2988 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information