Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow adding of subscribers during the
Client::factory
method.This is used in a user of this, but it looks like it would have never worked. 🤷♂️
As the
HttpClient
is hidden from the user, the only options the user has is to attach the subscriber on every request. This makes it available to all requests.Other options would be to provide some passthrough to the actual http client, or have an
attachSubscriber
method on theGuzzleClient
object.