forked from biologist79/ESPuino
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add first draft of the bluetooth feature. swtiching between wifi and …
…bt is done via wifiEnabled flag and reboot
- Loading branch information
Showing
2 changed files
with
101 additions
and
308 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
af71640
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a question: saw you added
request->send_P(200, "text/html", management_HTML, templateProcessor);
=> so have you been able to serve the big mgmt-html-file (including your filebrowser) via flash?However, thanks for your contribution. I'm lagging a bit at the moment regarding pull request - sorry :-)
Got a suggestion regarding toggling between BT and WiFi/audio: what about using a modification-card? So default would be Wifi/audio (or maybe default via GUI). But as you apply such a mod-card, it's toggled to BT. When I got you right, reboot isn't necessary to toggle, right?
af71640
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I tried to directly branch this feature from your master. I'm still a git noob, something might gone wrong. However, the html bug is now fixed and commited in my master.
And this shouldn't be a pull request for your master. It should only show, that bluetooth support is possible and how it can maybe achieved.
Nevertheless, if I have time, I can create a proper pull request with a "proper" implementation.
Regarding to the implemtation questions:
Yes, a modification card to toggle between the modes makes sense. But in a first step I would do the reboot. The reboot is quite fast. Without reboot you have to assure that all memory is released from the previous mode. With all these library dependencies it is hard to guarantee, that all libraries are freeing their memory properly.
Apart from the modification card it is maybe as well an option to switch into Bluetooth Mode, when a button is pressed during power on?