Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix bug in getting non-existent parameter #2986

Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
47586b3
Small fix for batch_filter (the tests already cover it).
Jun 11, 2021
b98bbb2
Merge remote-tracking branch 'upstream/develop' into develop
Jun 11, 2021
8d5a9c2
Merge remote-tracking branch 'upstream/develop' into develop
Jun 14, 2021
11a8cbb
Merge remote-tracking branch 'upstream/develop' into develop
Jun 16, 2021
52d01b5
Merge remote-tracking branch 'upstream/develop' into develop
Jun 17, 2021
71db414
Merge remote-tracking branch 'upstream/develop' into develop
Jun 17, 2021
3386267
Merge remote-tracking branch 'upstream/develop' into develop
Jun 18, 2021
198b958
Merge remote-tracking branch 'upstream/develop' into develop
Jun 18, 2021
0fd73b9
Merge remote-tracking branch 'upstream/develop' into develop
Jun 21, 2021
21deaf2
Merge remote-tracking branch 'upstream/develop' into develop
Jun 21, 2021
3b4e8d4
Merge remote-tracking branch 'upstream/develop' into develop
Jun 21, 2021
b5f33e0
Merge remote-tracking branch 'upstream/develop' into develop
Jun 21, 2021
7605e8e
Merge remote-tracking branch 'upstream/develop' into develop
Jun 22, 2021
8c1954a
Merge remote-tracking branch 'upstream/develop' into develop
Jun 22, 2021
c80939c
Merge remote-tracking branch 'upstream/develop' into develop
Jun 22, 2021
7d5b0b2
Merge remote-tracking branch 'upstream/develop' into develop
Jun 22, 2021
82ad2d0
Merge remote-tracking branch 'upstream/develop' into develop
Jun 22, 2021
ca52774
Merge remote-tracking branch 'upstream/develop' into develop
Jun 23, 2021
daefbae
Merge remote-tracking branch 'upstream/develop' into develop
Jun 23, 2021
16b4569
Merge remote-tracking branch 'upstream/develop' into develop
Jun 24, 2021
dbe1d97
Merge remote-tracking branch 'upstream/develop' into develop
Jun 24, 2021
eaa8c0c
Merge remote-tracking branch 'upstream/develop' into develop
Jun 24, 2021
441081d
Merge remote-tracking branch 'upstream/develop' into develop
Jun 24, 2021
bc2c43c
Merge remote-tracking branch 'upstream/develop' into develop
Jun 25, 2021
e8e29fd
Merge remote-tracking branch 'upstream/develop' into develop
Jun 25, 2021
8a0d95b
Merge remote-tracking branch 'upstream/develop' into develop
Jun 25, 2021
da38e52
Merge remote-tracking branch 'upstream/develop' into develop
Jun 25, 2021
c3f89b5
Merge remote-tracking branch 'upstream/develop' into develop
Jun 25, 2021
695904e
Merge remote-tracking branch 'upstream/develop' into develop
Jun 28, 2021
44861bc
Merge remote-tracking branch 'upstream/develop' into develop
Jun 28, 2021
63a7d34
Merge remote-tracking branch 'upstream/develop' into develop
Jun 29, 2021
7d04a26
Merge remote-tracking branch 'upstream/develop' into develop
Jun 29, 2021
9cd7941
Merge remote-tracking branch 'upstream/develop' into develop
Jun 29, 2021
a9e7f7f
Merge remote-tracking branch 'upstream/develop' into develop
Jun 30, 2021
75d1712
Merge remote-tracking branch 'upstream/develop' into develop
Jun 30, 2021
5217c67
Merge remote-tracking branch 'upstream/develop' into develop
Jun 30, 2021
1c079d5
Merge remote-tracking branch 'upstream/develop' into develop
Jul 1, 2021
f924d12
Merge remote-tracking branch 'upstream/develop' into develop
Jul 1, 2021
d7c9d51
Merge remote-tracking branch 'upstream/develop' into develop
Jul 2, 2021
2a1e39c
fix minor bug in parameter getter
Jul 2, 2021
8738fb9
Merge remote-tracking branch 'upstream/develop' into develop
Jul 3, 2021
886a716
Merge branch 'develop' into bugfix/GE-160/GE-314/alexsherstinsky/fix_…
Jul 3, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -329,15 +329,23 @@ def _get_parameter_value_from_parameter_container(

parameter_name_part: Optional[str] = None
return_value: Optional[Union[Any, ParameterNode]] = parameter_node
parent_parameter_node: Optional[ParameterNode] = None
try:
for parameter_name_part in fully_qualified_parameter_name_as_list:
parent_parameter_node = return_value
if parameter_name_part in return_value:
return_value = return_value[parameter_name_part]

except KeyError:
raise KeyError(
f"""Unable to find value for parameter name "{fully_qualified_parameter_name}": Part \
"{parameter_name_part}" does not exist in fully-qualified parameter name.
"""
)
if parameter_name_part not in parent_parameter_node:
raise KeyError(
f"""Unable to find value for parameter name "{fully_qualified_parameter_name}": Part \
"{parameter_name_part}" of fully-qualified parameter name does not exist.
"""
)

Expand Down