Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add
run_profiler_on_data
method to DataContext #4190[FEATURE] Add
run_profiler_on_data
method to DataContext #4190Changes from 9 commits
cb84e96
c84dba1
29b9b19
7a0718e
f6c244f
e6b5c30
89e3b0d
f567035
24a07cf
d1be8fd
0bfc783
becd7f2
376b80b
58d4cf2
c50e425
159ffcf
859e03c
3372e83
f90e4d5
dd522bb
e268230
b7aea71
9e7100e
cabcf81
a710eab
163deff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdkini I feel that it makes sense to do something here that will make this method applicable to any and all column domain builders. The question that arises would be: what do we do for custom-built column type domain builders, which users might develop (and we have one example of it in tests, which @anthonyburdi developed). Might it make sense to set up a top-level column domain builder class and require any column domain builder to extend it? Happy to brainstorm. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're referring to
MyCustomSemanticTypeColumnDomainBuilder
?I think there are two reasonable solutions:
ColumnDomainBuilder
- I think not doing so is a configuration error. How do we enforce that?DomainBuilder
subclass type) and only use it in the applicable cases - this may be confusing but would be easier to implement.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same note about downstream arguments - should this be streamlined?