Fix str vs bytes issue in Console #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in greatfet console that causes runtime errors on Windows and in certain cases on nix-based OSes when using greatfet uart functionality. NTConsole (and in certain cases POSIXConsole) emit `str` types when keys are pressed, `greatfet_uart.py` is written to expect keys as `bytestring`. Since Console is currently only used by the UART functionality, this commit changes the Console to return only `bytestring`s when polled for keypresses.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in greatfet console that causes runtime errors on Windows and in certain cases on nix-based OSes when using greatfet uart functionality.
NTConsole (and in certain cases POSIXConsole) emit
strtypes when keys are pressed,greatfet_uart.pyis written to expect keys asbytestring. Since Console is currently only used by the UART functionality, this commit changes the Console to return onlybytestrings when polled for keypresses.