Proposed changes to give user friendlier messages on missing cloneType #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new GetReferenceException to builder - catch .get on None in emitType on aggregate - Throw partially filled in GetReferenceException -
grebe
requested changes
Oct 17, 2018
| catch { | ||
| case getRef: GetReferenceException => | ||
| throw new GetReferenceException(s"Cannot emit ports for ${d.className}" + | ||
| s" with fields ${d.elements.keys.mkString(",")}, perhaps cloneType is not defined") |
There was a problem hiding this comment.
I think the error message should say "perhaps you forgot a cloneType"- I think this is about calling cloneType on bundle fields, not defining cloneType for the bundle.
grebe
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is a stab at providing some useful information