-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose firestore query errors #26
Expose firestore query errors #26
Conversation
I noticed that tests are failing in the Travis CI build, but they are passing locally for me. Would I be able to get assistance in resolving this? |
@aaaronMF thank you so much for jumping on this! |
@aaaronMF - I pulled down your branch and am seeing the test failures that are in TravisCI locally. When you run Also, can we remove the |
…n and FirestoreDocument when errors occur; add testing for firestore query error handling
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 6 6
Lines 78 80 +2
Branches 18 18
=====================================
+ Hits 78 80 +2
Continue to review full report at Codecov.
|
Tests are passing now. @warbrett pointed out I should run yarn install instead of using npm to ensure the correct package versions are being used. |
What do you think @green-arrow? |
Wooohoooo!! Thanks @green-arrow 😃 🙏🎇🚀🌟 |
Closes #12.
The code from @sampl was slightly modifed in order for existing tests to pass, and tests were added to ensure that the FirestoreCollection and FirestoreDocument components react accordingly to firestore query errors.