[green-code-initiative/ecoCode#336] Adds Maven Wrapper #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedece35
requested changes
Sep 1, 2024
This Maven Wrapper is an easy way to ensure a developer has everything necessary to build this project. Executed command to add wrapper to project: ```sh mvn wrapper:wrapper -Dmaven=3.9.9 ```
… version used across different environments)
jycr
force-pushed
the
feature/maven-wrapper
branch
from
5300df1 to
b1abd7b
Compare
Done :) |
|
dedece35
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
ok for me ... I create a Kanban ticket to create the same PR on each other ecoCode project and upgrade check_requirements tool finally.
please see ticket https://github.com/orgs/green-code-initiative/projects/2/views/1?pane=issue&itemId=78854739
another idea : think if it is possible to upgrade this maven wrapper system to create an common and abstract way to make it easier to upgrade all projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Maven Wrapper is an easy way to ensure a developer has everything necessary to build this project.
Executed command to add wrapper to project:
This PR fix green-code-initiative/creedengo-rules-specifications#336 for ecoCode-java plugin
Also, migrate scripts to use Maven Wrapper (to ensure consistency of Maven version used in different environments)