Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ec522 avoid brightness override #42

Merged
merged 13 commits into from
Jun 5, 2024
Merged

Ec522 avoid brightness override #42

merged 13 commits into from
Jun 5, 2024

Conversation

JuBaas
Copy link
Contributor

@JuBaas JuBaas commented May 30, 2024

associated to the following issue :
#39

@utarwyn utarwyn added 🗃️ rule Impacts a rule 🏆 challenge 🏆 Work done during the ecoCode Challenge labels May 30, 2024
utarwyn
utarwyn reviewed May 30, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
eslint-plugin/lib/rules/avoid-brightness-override.js Outdated Show resolved Hide resolved
@utarwyn utarwyn mentioned this pull request May 31, 2024
Merged
utarwyn
utarwyn requested changes Jun 2, 2024
View reviewed changes
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the Java class into CheckList.java file? The rule will not be added to SonarQube without it @JuBaas

@JuBaas JuBaas force-pushed the EC522-avoid-brightness-override branch from 27f3a9f to 7208bcf Compare June 4, 2024 08:59
@utarwyn utarwyn linked an issue Jun 5, 2024 that may be closed by this pull request
Implements rules EC522 "avoid brightness override" for react native and expo framework #39
Closed
utarwyn
utarwyn approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 Thank you for the work!

@utarwyn utarwyn merged commit 4f8ec12 into green-code-initiative:main Jun 5, 2024
2 checks passed
@utarwyn utarwyn deleted the EC522-avoid-brightness-override branch June 5, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utarwyn utarwyn utarwyn approved these changes

Assignees

@JuBaas JuBaas

Labels
🏆 challenge 🏆 Work done during the ecoCode Challenge 🗃️ rule Impacts a rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implements rules EC522 "avoid brightness override" for react native and expo framework
2 participants
@JuBaas @utarwyn