Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EC34 replaced by EC35 : PHP implementation #10

Merged
merged 10 commits into from
Dec 10, 2023
Merged

EC34 replaced by EC35 : PHP implementation #10

merged 10 commits into from
Dec 10, 2023

Conversation

dedece35
Copy link
Member

3nd PR for TODO tasks mentionned in PR green-code-initiative/creedengo-rules-specifications#128

waiting for new release of rules-specifications before merging this PR ... see PR green-code-initiative/creedengo-rules-specifications#236 : once merged and a new manual release fo ecocode-rules-specifications done, use it on pom.xml

@dedece35 dedece35 added 🏗️ refactoring refactoring for best practices 🗃️ rule rule improvment or rule development or bug labels Oct 24, 2023
@dedece35 dedece35 requested review from glalloue and jhertout October 24, 2023 09:08
@dedece35 dedece35 self-assigned this Oct 24, 2023
@dedece35 dedece35 marked this pull request as draft October 24, 2023 09:09
This was referenced Oct 24, 2023
Merged
Closed
@dedece35 dedece35 marked this pull request as ready for review October 27, 2023 19:39
@dedece35 dedece35 requested a review from utarwyn October 28, 2023 20:49
utarwyn
utarwyn requested changes Oct 29, 2023
View reviewed changes
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a problem with the coverage... can you have a look?

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dedece35
Copy link
Member Author

dedece35 commented Nov 1, 2023 •
edited
Loading

There seems to be a problem with the coverage... can you have a look?

After analysis, I realize that the coverage is 0% also on main branch on all other code.
I think there is a problem with coverage on PHP repository.
For me, the problem would be corrected on an specific issue, if you agree with me ... issue created #12

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2023

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 2, 2023
@dedece35
Copy link
Member Author

dedece35 commented Dec 4, 2023

There seems to be a problem with the coverage... can you have a look?

After analysis, I realize that the coverage is 0% also on main branch on all other code. I think there is a problem with coverage on PHP repository. For me, the problem would be corrected on an specific issue, if you agree with me ... issue created #12

are you ok @utarwyn ?

@github-actions github-actions bot removed the stale label Dec 5, 2023
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dedece35 dedece35 merged commit daacdb2 into main Dec 10, 2023
2 of 3 checks passed
@dedece35 dedece35 deleted the EC34-replace branch December 10, 2023 21:02
@utarwyn utarwyn mentioned this pull request Dec 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utarwyn utarwyn utarwyn requested changes

@glalloue glalloue Awaiting requested review from glalloue

@jhertout jhertout Awaiting requested review from jhertout

Assignees

@dedece35 dedece35

Labels
🏗️ refactoring refactoring for best practices 🗃️ rule rule improvment or rule development or bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dedece35 @utarwyn