Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lmangaretto renommage PHP #38

Merged
merged 11 commits into from
Dec 16, 2024

Conversation

Lmgrto
Copy link
Contributor

@Lmgrto Lmgrto commented Nov 8, 2024

renaming ecocode to creedengo

Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take into account same review feedback in creedengo-python repository

@dedece35 dedece35 assigned dedece35 and Lmgrto and unassigned dedece35 Nov 18, 2024
@dedece35 dedece35 added 🔰 good first issue Good for newcomers 🏗️ refactoring refactoring for best practices 🔥 in progress 🔥 labels Nov 18, 2024
@Lmgrto
Copy link
Contributor Author

Lmgrto commented Nov 19, 2024

please take into account same review feedback in creedengo-python repository

corrected

CHANGELOG.md Outdated Show resolved Hide resolved
RULES.md Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@Lmgrto
Copy link
Contributor Author

Lmgrto commented Dec 16, 2024

Fixed requested PR changes, and added rules migration from EC to GCI

@dedece35 dedece35 merged commit 2d50dc7 into green-code-initiative:main Dec 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔰 good first issue Good for newcomers 🏗️ refactoring refactoring for best practices 🔥 in progress 🔥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants