Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate handlers to single Mousetrap binding #2

Closed
chrisui opened this issue Apr 8, 2015 · 5 comments
Closed

Delegate handlers to single Mousetrap binding #2

chrisui opened this issue Apr 8, 2015 · 5 comments

Comments

@chrisui
Copy link
Contributor

chrisui commented Apr 8, 2015

HotKeys currently creates a Mousetrap instance for each component mounted. This could be optimized for the cases where you had many hotkey targets (imagine hundreds of node's you had a 'delete' hotkey for) by having a single instance where handlers were bound to.

@chrisui
Copy link
Contributor Author

chrisui commented Apr 8, 2015

Having a single HotKeyManager would also solve the issue seen here. If a deep handler is triggered for a key sequence which is a subset of a root sequence (Eg. up in up down left right) then the root sequence would never fire!

@chrisui
Copy link
Contributor Author

chrisui commented Apr 13, 2015

Note with 98b65bc the propagation issue seen in the mentioned example is now fixed.

A single delegation point should still be written though for best performance moving forwards.

@chrisui chrisui mentioned this issue Jul 22, 2016
8 tasks
@chrisui
Copy link
Contributor Author

chrisui commented Jul 22, 2016

Closing to be tracked in #2

Might re-open if it drops from v1 scope.

@greena13
Copy link
Owner

Reopening to track separately.

@greena13 greena13 reopened this Nov 19, 2017
@greena13
Copy link
Owner

greena13 commented Jan 5, 2019

Closing as soon to be no longer relevant, with the removal of Mousetrap in version 2.0.0

@greena13 greena13 closed this as completed Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants