Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: a get_trash command for every resource type #162

Merged
merged 10 commits into from
Feb 27, 2024
Merged

Add: a get_trash command for every resource type #162

merged 10 commits into from
Feb 27, 2024

Conversation

mattmundell
Copy link
Contributor

What

Split the get_trash command into multiple commands.

Why

This allows GSA to run the commands simultaneously, which means that the GMP requests happen concurrently. With a single get_trash command each GMP request would have to wait for the previous request to finish.

References

Similar PR for scan configs: /pull/146

@mattmundell mattmundell requested a review from a team as a code owner January 4, 2024 09:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

Conventional Commits Report

Type Number
Added 2

🚀 Conventional commits found.

@mattmundell mattmundell marked this pull request as draft January 4, 2024 09:37
@mattmundell mattmundell mentioned this pull request Jan 4, 2024
Merged
@mattmundell mattmundell changed the title Add: new cmd get_trash_targets Add: a get_trash command for every resource type Jan 4, 2024
@mattmundell mattmundell marked this pull request as ready for review January 8, 2024 13:59
a-h-abdelsalam
a-h-abdelsalam reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@a-h-abdelsalam a-h-abdelsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You may want to resolve the conflicts to include the new resource type report_configs.

@mattmundell
Copy link
Contributor Author

Looks good! You may want to resolve the conflicts to include the new resource type report_configs.

Thanks, resolved.

@a-h-abdelsalam a-h-abdelsalam merged commit 55747e6 into greenbone:main Feb 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-h-abdelsalam a-h-abdelsalam a-h-abdelsalam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @a-h-abdelsalam