[CMake] Do not install run(-time) dir(ectory) #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing the empty GSAD_RUN_DIR serves no purpose. The run(-time) directories of services should be dynamically created and not statically installed. And gsad's systemd service file ensures that the PIDFile is created, which is the only content of gsad's run directory. And even if there would be further content, then systemd's RuntimeDirectory directive should be used instead (as it is already done for gvmd). The bottom line is: in no case should run-time directories be installed, they are to be created at *run-time*.
bjoernricks
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing the empty GSAD_RUN_DIR serves no purpose. The run(-time)
directories of services should be dynamically created and not
statically installed. And gsad's systemd service file ensures that the
PIDFile is created, which is the only content of gsad's run
directory. And even if there would be further content, then systemd's
RuntimeDirectory directive should be used instead (as it is already
done for gvmd).
The bottom line is: in no case should run-time directories be
installed, they are to be created at run-time.