Add --rebuild-scap option (master) #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option allows rebuilding SCAP data of a given type. Currently only OVAL definitions are supported.
The value from the initialization in rebuild_scap is never read.
This was overlooked while porting the --rebuild-scap option from gvmd-8.0. Co-Authored-By: Matt Mundell <32057441+mattmundell@users.noreply.github.com>
The code for opening the lockfile and updating the data is now moved to new functions shared between sync_scap and rebuild_scap. This gets rid of some duplication and also makes the way the locking works more consistent.
The rebuild_scap now handles the return code from open_secinfo_lockfile and unused failure return codes have been removed from manage_rebuild_scap and its documentation.
mattmundell
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows rebuilding SCAP data of a given type.
Currently only OVAL definitions are supported.
Checklist: