Fix report host end time check in CVE scans #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking up the latest finished report_host for a CVE scan, the query will also consider the end_time being set to 0 instead of NULL when the scan of the host is unfinished. Without this the CVE scan could return no or less results for hosts being scanned at the moment.
timopollmeier
added
backport-to-21.04
backport-to-main
bjoernricks
approved these changes
Mar 24, 2021
This was referenced Mar 24, 2021
|
@timopollmeier @bjoernricks Looks like this could also fix #1385 or am i wrong? |
timopollmeier
added a commit
that referenced
this pull request
Mar 24, 2021
Fix report host end time check in CVE scans (bp #1462)
timopollmeier
added a commit
that referenced
this pull request
Mar 24, 2021
Fix report host end time check in CVE scans (bp #1462)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
When looking up the latest finished report_host for a CVE scan, the
query will also consider the end_time being set to 0 instead of NULL
when the scan of the host is unfinished.
Why:
Without this the CVE scan could return no or less results for hosts
being scanned at the moment.
How did you test it:
Without the fix the second CVE scan produced no results, while it produces the same results as the first scan with the fix.
Checklist: