Remove using "host_start" and "host_end" in RFPs. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These elements are going to be removed and are redundant anyway. The RFPs are patched to work with them and rather ise host/start and host/end instead. * report_formats/sourcefire/sourcefire.xsl (template match="host"): New, replace host_start to create "AddHost" output. (template match="report"): Apply "host", not "host_start". (template match="host_start", template match="host_end"): Removed, not needed anymore to filter out. * src/report_formats/HTML/HTML.xsl: Use "host" instead of "host_start" to count and iterate over hosts. * src/report_formats/LaTeX/latex.xsl (name="results-overview"): Use "host" instead of "host_start" to trigger host authentication success. * src/report_formats/NBE/NBE.xsl (match="report"): Instead of host_start use host/start. Don't try to consider host_end which was going wrong anyway (equal to host_start). Rather use host/end. This fixes also the bug about the host_end being equal to host_start. Call template "ctime" properly with a param. * src/report_formats/TXT/TXT.xsl (template name="real-report"): Instead of "host_start" use "host" for count of hosts. * src/report_formats/Verinice_ISM/Verinice_ISM.xsl (match="/", match="report/host_start"): Use "host" instead of "host_start" to trigger host iterator. * src/report_formats/Verinice_ISM/Verinice_ITG.xsl (match="/", match="report/host_start"): Use "host" instead of "host_start" to trigger host iterator.
timopollmeier
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These elements are going to be removed and are redundant
anyway. The RFPs are patched to not work with them and rather
use host/start and host/end instead.
report_formats/sourcefire/sourcefire.xsl
(template match="host"): New, replace host_start to create "AddHost" output.
(template match="report"): Apply "host", not "host_start".
(template match="host_start", template match="host_end"): Removed,
not needed anymore to filter out.
src/report_formats/HTML/HTML.xsl: Use "host" instead of "host_start"
to count and iterate over hosts.
src/report_formats/LaTeX/latex.xsl (name="results-overview"): Use
"host" instead of "host_start" to trigger host authentication success.
src/report_formats/NBE/NBE.xsl (match="report"): Instead of
host_start use host/start. Don't try to consider host_end
which was going wrong anyway (equal to host_start). Rather use
host/end. This fixes also the bug about the host_end being equal
to host_start. Call template "ctime" properly with a param.
src/report_formats/TXT/TXT.xsl (template name="real-report"):
Instead of "host_start" use "host" for count of hosts.
src/report_formats/Verinice_ISM/Verinice_ISM.xsl (match="/",
match="report/host_start"):
Use "host" instead of "host_start" to trigger host iterator.
src/report_formats/Verinice_ISM/Verinice_ITG.xsl (match="/",
match="report/host_start"):
Use "host" instead of "host_start" to trigger host iterator.