Fix issue #611

[vulnbe]

This PR fixes bug described here #611

• Tests
• CHANGELOG

[timopollmeier]

I don't see why the table_schema = 'public' is evaluated before the pg_get_serial_sequence call in the WITH clause but not the original SELECT, so I'm not sure if it's safe to assume this is always the case.

Wouldn't it be safer to only select table_name and column_name (filtered by table_schema) in the WITH clause and then use pg_get_serial_sequence on those rows?

For example:

WITH table_columns AS (SELECT table_name, column_name FROM information_schema.columns WHERE table_schema = 'public')
SELECT *, pg_get_serial_sequence (table_name, column_name) FROM table_columns
WHERE pg_get_serial_sequence (table_name, column_name) IS NOT NULL;

or maybe

WITH table_columns AS (SELECT table_name, column_name FROM information_schema.columns WHERE table_schema = 'public'),
serial_sequences AS (SELECT *, pg_get_serial_sequence (table_name, column_name) AS p FROM table_columns)
SELECT * FROM serial_sequences WHERE p IS NOT NULL;

[mattmundell]

I presume that WITH clauses are always evaluated before the selected columns, but I did expect a solution like Timo's first example (because it's clearer that the pg_get_serial_sequence is done later).

Don't mind either way, but would like to see a summary of the explanation from #611 in a comment above the statement.

[mattmundell]

Thank you!

[asmaack]

Will you merge this into gvmd-8.0 as well?
:-)

[mattmundell]

Will you merge this into gvmd-8.0 as well?
:-)

PR for this: #691