Do not pass in SQL string vars as format strings #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some sql and init_iterator calls were passing in variables with complete SQL strings in place of the format strings. If the SQL in the variable contained substrings that resembled placeholders like '%s' they would be replaced with garbage data.
timopollmeier
force-pushed
the
sql-format-string-fix
branch
from
59002b9 to
48ed464
Compare
mattmundell
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sql and init_iterator calls were passing in variables with complete
SQL strings in place of the format strings. If the SQL in the variable
contained substrings that resembled placeholders like '%s' they would
be replaced with garbage data.
Checklist: