Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round 4 of OTP cleanout #735

Merged
merged 15 commits into from
Sep 4, 2019
Merged

Round 4 of OTP cleanout #735

merged 15 commits into from
Sep 4, 2019

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Sep 3, 2019 •
edited
Loading

Checklist:

@mattmundell
Correct doc of process_gmp
691cefd
@mattmundell
Remove handling of old process_gmp returns
37151f2
@mattmundell
Correct return doc of manage_run_wizard
2c00f6d
@mattmundell
Remove forked == 2 checks
2e98210 
forked is never 2 anymore, as we no longer have the current_error
hack that was used to prevent the scan handlers from forking
again.  With OTP gone the forked scan handlers never return to the
main loop, and they make their own scanner connections, so these
checks are not required.

This patch is much clearer when ignoring whitespace.
@mattmundell
Remove fork return from process_gmp_client_input
a90c054 
We are no longer doing anything special with this return, as we no longer
need to worry about forking of OTP tasks.
@mattmundell
Remove fork return from process_gmp
a6b3e1c 
We no longer have forking of task with OTP scanner connections, so
there's no need for special handling in a parent that forks a task
handler.
@mattmundell
Remove out of date manage_run_wizard return
90e5e11
@mattmundell
Remove 'forked', no longer used
00ff882
@mattmundell
Update notes referring to to_scanner
cbc8aea
@mattmundell
Correct stop_task returns
da2f419
@mattmundell
Remove out of date manage_run_wizard return case
d02e111
@mattmundell mattmundell changed the title Otp cleanup 4 Round 4 of OTP cleanout Sep 3, 2019
@mattmundell
Remove remains of NVT update mode from serve_gmp
b23c580 
This is now done directly, by update_nvt_cache_osp.
@mattmundell
Remove client_active from serve_gmp
b4ba3a3 
The client is always active now that OTP has been removed.
@mattmundell
Correct small typo
b27d0f0
@mattmundell mattmundell marked this pull request as ready for review September 3, 2019 16:30
@timopollmeier timopollmeier merged commit 09a9e87 into greenbone:master Sep 4, 2019
@mattmundell mattmundell deleted the otp-cleanup-4 branch September 4, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @timopollmeier