Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move report format dirs when inheriting user #989

Merged
merged 4 commits into from
Feb 24, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Feb 21, 2020

Checklist:

@mattmundell mattmundell marked this pull request as ready for review February 21, 2020 11:09
@mattmundell mattmundell added the work in progress This pull request should not be merged yet, more commits are expected label Feb 21, 2020
@mattmundell mattmundell removed the request for review from timopollmeier February 21, 2020 11:20
return;
}

old_dir = g_build_filename (GVMD_STATE_DIR,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be wrong for old predefined report formats. Their owner is changed in migrate_predefined_report_formats, but their files will still be in the old special dir (and not in the owner's report format dir). I'll fix this in a new PR.

@mattmundell mattmundell removed the work in progress This pull request should not be merged yet, more commits are expected label Feb 21, 2020
@mattmundell mattmundell merged commit 838fc33 into greenbone:master Feb 24, 2020
@mattmundell mattmundell deleted the inherit-rf branch February 24, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants