Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print UUIDs in --get-users when --verbose given #991

Merged
merged 3 commits into from
Feb 24, 2020
Merged

Print UUIDs in --get-users when --verbose given #991

merged 3 commits into from
Feb 24, 2020

Conversation

mattmundell
Copy link
Contributor

Checklist:

@mattmundell mattmundell marked this pull request as ready for review February 24, 2020 14:09
bjoernricks
bjoernricks approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if --verbose is really required but I guess you just wanted to not break existing scripts relying on the old/current output of --get-users

@mattmundell
Copy link
Contributor Author

Not sure if --verbose is really required but I guess you just wanted to not break existing scripts relying on the old/current output of --get-users

Yes, I would prefer without --verbose, but I don't want trouble.

@mattmundell mattmundell merged commit e95b267 into greenbone:master Feb 24, 2020
@mattmundell mattmundell deleted the verbose-users branch February 24, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

@timopollmeier timopollmeier Awaiting requested review from timopollmeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @bjoernricks