-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snapshot testing for statement parsing #1765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files
|
Kraemii
commented
Nov 20, 2024
Kraemii
commented
Nov 20, 2024
Kraemii
force-pushed
the
snapshot-test
branch
from
November 20, 2024 09:28
561a05d
to
4da2a1b
Compare
Tehforsch
previously requested changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Kraemii
force-pushed
the
snapshot-test
branch
from
November 21, 2024 11:02
4da2a1b
to
b4e4683
Compare
Kraemii
force-pushed
the
snapshot-test
branch
from
November 25, 2024 10:50
b4e4683
to
eb7fa2c
Compare
Kraemii
commented
Nov 25, 2024
nichtsfrei
force-pushed
the
snapshot-test
branch
from
December 16, 2024 17:24
eb7fa2c
to
40e3972
Compare
For statements it is hard to write any unit tests, as a statement is a rather complex struct also containing some meta information. It is much easier to test the statement parsing, looking at the generated statement and review it instead.
nichtsfrei
force-pushed
the
snapshot-test
branch
from
December 16, 2024 17:24
40e3972
to
8ba174c
Compare
nichtsfrei
approved these changes
Dec 16, 2024
nichtsfrei
dismissed
Tehforsch’s stale review
December 16, 2024 17:27
everything is marked as resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For statements it is hard to write any unit tests, as a statement is a rather complex struct also containing some meta information. It is much easier to test the statement parsing, looking at the generated statement and review it instead.