-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mix in the mixins ..., refactoring unittests #254
Conversation
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 91.27% 96.87% +5.60%
==========================================
Files 13 18 +5
Lines 1077 3745 +2668
==========================================
+ Hits 983 3628 +2645
- Misses 94 117 +23
Continue to review full report at Codecov.
|
Sorry. This was like hell! Updating the tests was really horror. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at all code yet. Especially not at the test case changes.
I will already create a PR for the Mixins-Idea, so that you can track the progress @bjoernricks
So far this includes changes from:
This should already be covered by
gmpv8
:This now contains all new test cases, refactored with Mixins. Fixed many tests, test-names and more.
I don't really can check if I tested all possible cases ... there are >4000 tests now! ...
Checklist: