Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mix in the mixins ..., refactoring unittests #254

Merged
merged 17 commits into from
Aug 3, 2020

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Jul 6, 2020

I will already create a PR for the Mixins-Idea, so that you can track the progress @bjoernricks

So far this includes changes from:

This should already be covered by gmpv8:

This now contains all new test cases, refactored with Mixins. Fixed many tests, test-names and more.
I don't really can check if I tested all possible cases ... there are >4000 tests now! ...

Checklist:

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #254 into master will increase coverage by 5.60%.
The diff coverage is 99.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   91.27%   96.87%   +5.60%     
==========================================
  Files          13       18       +5     
  Lines        1077     3745    +2668     
==========================================
+ Hits          983     3628    +2645     
- Misses         94      117      +23     
Impacted Files Coverage Δ
gvm/protocols/gmpv7/gmpv7.py 99.12% <ø> (ø)
gvm/protocols/gmpv8/types.py 100.00% <ø> (ø)
gvm/protocols/gmpv9/types.py 95.38% <ø> (ø)
gvm/protocols/gmpv9/gmpv9.py 98.62% <98.62%> (ø)
gvm/protocols/gmpv208/gmpv208.py 98.96% <98.96%> (ø)
gvm/protocols/gmpv8/gmpv8.py 99.33% <99.33%> (ø)
gvm/protocols/gmp.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/types.py 100.00% <100.00%> (ø)
gvm/protocols/latest.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ce284...164ba04. Read the comment docs.

@y0urself y0urself changed the title WiP: mix in the mixins ... WiP: mix in the mixins ..., refactoring unittests Jul 8, 2020
@y0urself y0urself requested a review from bjoernricks July 8, 2020 13:38
@y0urself y0urself self-assigned this Jul 8, 2020
@y0urself y0urself marked this pull request as ready for review July 8, 2020 14:28
@y0urself y0urself requested a review from a team as a code owner July 8, 2020 14:28
@y0urself y0urself changed the title WiP: mix in the mixins ..., refactoring unittests mix in the mixins ..., refactoring unittests Jul 8, 2020
@y0urself
Copy link
Member Author

y0urself commented Jul 8, 2020

Sorry. This was like hell!

Updating the tests was really horror.
I think I destroyed some file history due to the requested naming changes by @bjoernricks

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at all code yet. Especially not at the test case changes.

gvm/protocols/gmpv208/gmpv208.py Outdated Show resolved Hide resolved
gvm/protocols/gmpv208/gmpv208.py Outdated Show resolved Hide resolved
gvm/protocols/gmpv208/gmpv208.py Outdated Show resolved Hide resolved
gvm/protocols/gmpv208/gmpv208.py Outdated Show resolved Hide resolved
gvm/protocols/gmpv208/gmpv208.py Outdated Show resolved Hide resolved
gvm/protocols/gmpv208/gmpv208.py Outdated Show resolved Hide resolved
gvm/protocols/gmpv208/gmpv208.py Outdated Show resolved Hide resolved
gvm/protocols/gmpv208/gmpv208.py Outdated Show resolved Hide resolved
gvm/protocols/gmpv208/gmpv208.py Outdated Show resolved Hide resolved
gvm/protocols/gmpv208/gmpv208.py Outdated Show resolved Hide resolved
@bjoernricks bjoernricks merged commit eefa9c4 into greenbone:master Aug 3, 2020
@y0urself y0urself deleted the mix_in_mixins branch January 10, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants