Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorp greenelab eslint config #128

Merged
merged 14 commits into from
Mar 31, 2020
Merged

incorp greenelab eslint config #128

merged 14 commits into from
Mar 31, 2020

Conversation

vincerubinetti
Copy link
Collaborator

  • install eslint-config-greenelab and prettier-config-greenelab
  • relint entire codebase

@vincerubinetti
Copy link
Collaborator Author

vincerubinetti commented Mar 30, 2020 •
edited
Loading

Create react app not respecting imported eslint rules for build per this issue. Going to try reverting CRA version to fix the build error.

dongbohu
dongbohu approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@dongbohu dongbohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment only. Feel free to close it.

src/util/object.js Outdated Show resolved Hide resolved
@vincerubinetti vincerubinetti merged commit e49d9cd into greenelab:master Mar 31, 2020
@vincerubinetti vincerubinetti deleted the eslint branch March 31, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongbohu dongbohu dongbohu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincerubinetti @dongbohu