Provide 8/25 status update #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way - codeclimate is angry that the list elements 2, 3, and 4 don't start at '1'. I'm not sure why the markdown linter is flagging that. |
| review. | ||
|
|
||
| In about a week, we plan to move into the phase where we start to vigorously | ||
| discuss this question for each area that the review will cover (currently also |
There was a problem hiding this comment.
Maybe instead of "discuss this question" it would be more clear to state something like: "discuss the overarching question" or "discuss the main question" or "discuss the guiding question".
|
@gwaygenomics tried to make that a bit more clear - success? |
|
I looked into the markdownlint question a bit - looks like we would have to set Rule MD029 to LGTM |
|
It's already merged, but I like the status update |
dhimmel
pushed a commit
to dhimmel/deep-review
that referenced
this pull request
Nov 3, 2017
Provide 8/25 status update
dhimmel
pushed a commit
to dhimmel/deep-review
that referenced
this pull request
Jan 11, 2018
By positioning the `body` element, we tell Hypothesis to use it (rather than the document) as the container element for the adder. (See hypothesis/client#487 for more information.) Closes: greenelab#90, hypothesis/client#619
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate a discussion of work to date and provide a set of steps to get new participants up to speed.