Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add results of manual calls of 500 DOIs from on- and off-campus #20

Merged
merged 11 commits into from
Jan 18, 2018

Conversation

jglev
Copy link

@jglev jglev commented Jan 17, 2018

This PR contains the completed 500-DOI sample, from on- and off-campus, with no "invalid" cells.

See this comment forward re: DOIs which possibly need to be manually edited for the off-campus column, depending on the outcome of that dicussion.

@dhimmel
Copy link
Contributor

dhimmel commented Jan 17, 2018

How risky / hard would it be to manually port the penn_access_date and open_access_date from the previous dataset. I think the rows are in the same order, so you may be able to copy and paste? This will make manual-doi-checks-500.tsv a bit nicer.

Otherwise, looks good to me once we resolve the login-wall determination.

@jglev
Copy link
Author

jglev commented Jan 18, 2018

How risky / hard would it be to manually port the penn_access_date and open_access_date from the previous dataset.

Not hard, and not risky, I think (I'll be careful, and post my code for doing so here using a JOIN approach rather than a cut-and-paste). I'll take care of it now.

@jglev
Copy link
Author

jglev commented Jan 18, 2018

This latest commit looks ok / not dangerous to me; @dhimmel, would you mind looking over the code, too, to confirm that it looks ok to you, as well?

@dhimmel
Copy link
Contributor

dhimmel commented Jan 18, 2018

The changes to manual-doi-checks-500.tsv in 5befc95 look good.

Can you confirm that login-walled articles are not considered access?

@jglev jglev force-pushed the penntext-accuracy branch from 42ce184 to afba7a1 Compare January 18, 2018 21:35
@jglev
Copy link
Author

jglev commented Jan 18, 2018

Following discussion in #15, I can confirm that I've manually change off-campus access to 0 for the following DOIs, as of afba7a1 (there are two commits because I amended the commit log to include an extra DOI and then git push --forced):

@dhimmel dhimmel merged commit f5f3de3 into greenelab:master Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants