Get/create user by login instead of mail address (backport #449) #451
Comments
marcelmay
pushed a commit
that referenced
this issue
Mar 30, 2022
#451) * Implements #449: Stores the authentication details in the moving message so that it is available in e.g. MessageDeliveryHandler * Since different authentication methods have different details, there's a AuthenticationState base interface with PlainAuthenticationState (with an additional authorizationId) and LoginAuthenticationState POJOs for the currently supported AUTH mechanisms LOGIN and AUTH. Other AUTH mechanisms may or may not have a username and/or password. * What I don't fully understand is why the SMTPState needs to be cleared so often. It's also cleared by the MailCommand, which removes the authentication details from the MovingMessage. I modfied the MailCommand so that it clears the SMTPState, but transfers the authentication details from the old moving message to the new one. We could also store the authentication details in the SMTPState as well, but that feels a bit redundant. * When I run the tests locally, the DummySSLServerSocketFactoryTest#testLoadKeyStoreViaSystemProperty fails, but that's because I don't have a certificate with an `amazonrootca1` in my system root key store (there is, e.g. a `debian:amazon_root_ca_1.pem` certificate and when I change the test to use that, it passes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Backport of #449 / PR #450
The text was updated successfully, but these errors were encountered: